JingsongLi commented on code in PR #8623:
URL: https://github.com/apache/paimon/pull/8623#discussion_r3592907361
##########
paimon-format/src/main/java/org/apache/paimon/format/parquet/ParquetReaderFactory.java:
##########
@@ -100,11 +104,26 @@ public class ParquetReaderFactory implements
FormatReaderFactory {
public ParquetReaderFactory(
Options conf, RowType readType, int batchSize, @Nullable
FilterCompat.Filter filter) {
+ this(conf, readType, batchSize, filter, null);
+ }
+
+ public static ParquetReaderFactory create(
+ Options conf, RowType readType, int batchSize, @Nullable
List<Predicate> predicates) {
+ return new ParquetReaderFactory(conf, readType, batchSize, null,
predicates);
+ }
+
+ private ParquetReaderFactory(
Review Comment:
Why create so many constructors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
