jerry-024 commented on code in PR #8702:
URL: https://github.com/apache/paimon/pull/8702#discussion_r3601567042
##########
paimon-eslib/pom.xml:
##########
@@ -115,7 +114,7 @@ under the License.
<repositories>
<repository>
<id>eslib-github</id>
-
<url>https://raw.githubusercontent.com/CrownChu/es-paimon-lib-releases/main/repository</url>
+
<url>https://raw.githubusercontent.com/CrownChu/es-paimon-lib-releases/eslib-1.0.7/repository</url>
Review Comment:
**[minor] Keep the ESLib release identifier in one Maven property.**
`1.0.7` is repeated in both dependency versions and in this repository URL.
A partial future bump can resolve against the wrong release repository or fail
unexpectedly. Could we define one `eslib.version` property and reuse it in all
three locations?
##########
.github/workflows/utcase-eslib.yml:
##########
@@ -0,0 +1,68 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+name: UTCase ESLib on JDK 11
+
+on:
+ push:
+ paths:
+ - 'paimon-api/**'
+ - 'paimon-common/**'
+ - 'paimon-eslib/**'
+ - 'paimon-test-utils/**'
+ - 'pom.xml'
+ - '.github/workflows/utcase-eslib.yml'
+ pull_request:
+ paths:
+ - 'paimon-api/**'
+ - 'paimon-common/**'
+ - 'paimon-eslib/**'
+ - 'paimon-test-utils/**'
+ - 'pom.xml'
+ - '.github/workflows/utcase-eslib.yml'
+
+env:
+ JDK_VERSION: 11
+ MAVEN_OPTS: -Dmaven.wagon.httpconnectionManager.ttlSeconds=30
-Dmaven.wagon.http.retryHandler.requestSentEnabled=true
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event_name }}-${{
github.event.number || github.run_id }}
+ cancel-in-progress: true
+
+jobs:
+ eslib_test:
+ runs-on: ubuntu-latest
+ timeout-minutes: 30
+
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
Review Comment:
**[minor] Make the job token scope explicit and avoid persisting checkout
credentials.**
This workflow runs Maven after checkout and does not need Git credentials.
Could we add top-level `permissions: contents: read` and set
`persist-credentials: false` on the checkout step? This prevents build plugins
or dependencies from reading a more capable token if repository defaults change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
