lxy-9602 commented on code in PR #8709:
URL: https://github.com/apache/paimon/pull/8709#discussion_r3607130877
##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaValidation.java:
##########
@@ -682,35 +682,40 @@ private static void validateMapStorageLayout(TableSchema
schema, CoreOptions opt
if (hasSharedShredding) {
validateMapSharedShreddingFileFormats(options);
validateMapSharedShreddingCompressions(options);
- validateUnsupportedTypesWithMapSharedShredding(schema);
- if (!schema.primaryKeys().isEmpty()) {
+ validateUnsupportedTypesWithMapSharedShredding(schema, options);
+ if (options.bucket() == BucketMode.POSTPONE_BUCKET) {
Review Comment:
This is because `PostponeBucketFileStoreWrite` forces the write format to
`Avro`, which makes map shared shredding no longer meaningful in that path. To
keep the change simple, I removed postpone support for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
