wwj6591812 commented on PR #8716: URL: https://github.com/apache/paimon/pull/8716#issuecomment-5019595999
> Thanks for this PR! I'm thinking that do we need to implement independent actions for both PK, Append and DataEvolution tables? If so, we may need to trigger different procedures according to the table type. > > Can we just implement one delete action but solve different table type independently just like spark? `org.apache.paimon.spark.commands.DeleteFromPaimonTableCommand` > > Now we could just mark PK and append-only tables as unsupported. Thanks for the suggestion. I have consolidated the implementation into the existing delete action, so users now have a single entry point and the action dispatches internally according to the target table type, similar to Spark's DeleteFromPaimonTableCommand. The existing primary-key delete path is retained for backward compatibility, Data Evolution append tables use the deletion-vector implementation introduced by this PR, and regular append-only tables remain explicitly unsupported. I also removed the separate data_evolution_delete factory and identifier, moved its options into DeleteActionFactory, and updated the documentation and tests, including the bounded external source filtering case. All 15 targeted PK, Data Evolution, and procedure tests pass. @steFaiz @JingsongLi Please CC, Thx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
