sundapeng commented on PR #8730:
URL: https://github.com/apache/paimon/pull/8730#issuecomment-5024991042
Closing in favour of a re-split of this work.
The implementation changed enough since this split that updating the branch
in
place would replace every line and leave the review comments pointing at code
that no longer exists:
- the serializable provider with its 30s listing cache and JVM-wide
generation
counter is gone, replaced by a partition manager that creates one catalog
per
operation and closes it;
- the managed scan subclass is gone, folded into `FormatTableScan`;
- the two procedures are gone; `MSCK REPAIR TABLE` is the only entry point;
- the feature no longer reuses `metastore.partitioned-table`. It has its own
option, `format-table.partition-source = filesystem | rest`, so a
catalog-level default set for Paimon tables cannot turn it on for a Format
Table by accident.
The review comments here are all addressed; the new PRs describe how.
Replaced by:
- core: #8750
- spark: #8751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
