thswlsqls opened a new pull request, #8756:
URL: https://github.com/apache/paimon/pull/8756

   ### Purpose
   
   fix #8755
   
   - Wrap the `LocalFileIO.LocalSeekableInputStream` of five `benchmark/bitmap` 
cases in try-with-resources: `RoaringBitmapBenchmark.testDeserialize()` (second 
case), `BitmapIndexBenchmark.query()`, and 
`RangeBitmapIndexBenchmark.queryBsi()` / `queryBitmap()` / `queryRangeBitmap()`.
   - The other three cases in `RoaringBitmapBenchmark.testDeserialize()` 
already use try-with-resources — the second case was the only one missing it.
   - `LocalFileIO.LocalSeekableInputStream.close()` closes the underlying 
`FileInputStream`, so without it release is left to the GC.
   - Widen `catch (FileNotFoundException)` to `catch (IOException)` in the four 
query methods, required now that `close()` is on the path. The measured logic 
is unchanged.
   
   ### Tests
   
   - No test added: this module has no `*Test` class (all 17 files are 
benchmarks) and the change only affects cleanup.
   - `mvn spotless:check` and `mvn -DskipTests clean test-compile` on 
`paimon-benchmark/paimon-micro-benchmarks` passed.
   - The `@Test` methods here run real benchmarks, so they were not run locally.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to