thswlsqls opened a new pull request, #8761:
URL: https://github.com/apache/paimon/pull/8761

   ### Purpose
   
   - The `FileChannelManagerImpl` constructor comment claims directories are 
created "after registering shutdown hook", but no shutdown hook is registered 
in the class.
   - It was carried over from the original Flink port (FLINK-30610), which 
registers the hook; the Paimon port dropped it but kept the comment.
   - Reword the comment to describe the actual cleanup contract: directories 
are removed in `close()`.
   
   ### Tests
   
   - Comment/wording fix, no behavior change — no test added. `mvn 
spotless:check -pl paimon-core` passed, and `mvn -pl paimon-core -DskipTests 
test-compile` (checkstyle + spotless) BUILD SUCCESS under JDK 11.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to