thswlsqls opened a new pull request, #8763:
URL: https://github.com/apache/paimon/pull/8763

   
   ### Purpose
   
   fix #8762
   
   - `GenerateUtils.generateMapCompare` built the value array type from 
`mapType.getKeyType` instead of `getValueType`, so the generated comparator 
read `MAP` value elements with the key type.
   - For maps whose key and value types differ (e.g. `MAP<INT, STRING>`) this 
gave a wrong comparison result or a runtime `ClassCastException`.
   - Sibling `generateMultisetCompare` and 
`ScalarOperatorGens.generateMapComparison` already pass key and value types 
separately.
   
   ### Tests
   
   - Added `CodeGenUtilsTest#testMapComparatorComparesValuesWithValueType` 
comparing `MAP<INT, STRING>` rows with equal keys and differing values; it 
fails (ClassCastException) before the fix and passes after.
   - `mvn -pl paimon-core -Dtest=CodeGenUtilsTest test` — 15 tests passed (JDK 
11). `mvn -pl paimon-codegen,paimon-core spotless:check` passed.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to