ifndef-SleePy commented on PR #8671: URL: https://github.com/apache/paimon/pull/8671#issuecomment-5035647176
Two design concerns: 1. It would be better to avoid blocking operations in the coordinator main thread, since this may block the JM main thread. (Update: Looks like your latest PR has already changed the implementation. The current approach looks more acceptable.) 2. It would be good to think through the failover cases carefully, for example task failover or global failover after some tasks have already sent end input. A few small suggestions: 1. For complex logic like failover handling, it would be helpful to explain the design in a more structured way (maybe in the PR description or in comments), including how each failover case is handled. Otherwise, it is hard to tell from many `if-else` branches whether the code is fully correct. 2. It would be necessary to cover all cases with tests (especially the failover scenario), including both UTs and ITs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
