XiaoHongbo-Hope commented on code in PR #590:
URL: https://github.com/apache/paimon-rust/pull/590#discussion_r3637315414
##########
crates/paimon/src/table/table_scan.rs:
##########
@@ -1030,6 +1086,111 @@ impl<'a> PaimonTableScan<'a> {
can_push_down_limit_hint_for_scan(&self.data_predicates, row_ranges)
}
+ fn global_index_scan_settings(
+ &self,
+ core_options: &CoreOptions,
+ data_evolution_enabled: bool,
+ ) -> crate::Result<Option<GlobalIndexScanSettings>> {
+ if data_evolution_enabled
+ && core_options.global_index_enabled()
+ && !self.data_predicates.is_empty()
+ {
+ Ok(Some(GlobalIndexScanSettings {
+ search_mode: core_options.global_index_search_mode()?,
+ thread_num: core_options.global_index_thread_num()?,
+ }))
+ } else {
+ Ok(None)
+ }
+ }
+
+ async fn read_index_manifest_entries(
+ &self,
+ snapshot: &Snapshot,
+ ) -> crate::Result<Option<Vec<IndexManifestEntry>>> {
+ let Some(index_manifest_name) = snapshot.index_manifest() else {
+ return Ok(None);
+ };
+ let table_path = self.table.location().trim_end_matches('/');
+ let path =
format!("{table_path}/{MANIFEST_DIR}/{index_manifest_name}");
+ Ok(Some(
+ IndexManifest::read(self.table.file_io(), &path).await?,
+ ))
+ }
+
+ async fn evaluate_global_index_row_ranges(
+ &self,
+ snapshot: &Snapshot,
+ index_entries: &[IndexManifestEntry],
Review Comment:
> Just for deletion-vectors? If it is. It needs to be in DV mode to be read.
And it should be filtered so that only DV remains.
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
