JingsongLi commented on PR #8800:
URL: https://github.com/apache/paimon/pull/8800#issuecomment-5057377672
- The rule only recognizes explicit/resolved `BROADCAST` hints.
- Spark’s normal statistics-based automatic broadcasting is determined
during the physical planning phase; since the logical plan contains no hints,
the limited streamed side will not be repartitioned, and there may still be
only one partition after the physical `BroadcastHashJoin`.
- Existing tests also only cover `/*+ BROADCAST(d) */`. It is recommended
to add cases without hints that rely on `autoBroadcastJoinThreshold`, or to
handle them at a stage where physical partitioning can be observed.
- The current `TableValuedFunctionsTest` passes 20 out of 20 locally,
indicating that the implementation within the existing test coverage is
correct; the issue is insufficient coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
