JingsongLi commented on code in PR #8845:
URL: https://github.com/apache/paimon/pull/8845#discussion_r3649207542
##########
paimon-core/src/main/java/org/apache/paimon/table/format/FormatTableScan.java:
##########
@@ -185,31 +195,13 @@ public List<Split> splits() {
try {
FileIO fileIO = table.fileIO();
if (!table.partitionKeys().isEmpty()) {
- for (Pair<LinkedHashMap<String, String>, Path> pair :
findPartitions()) {
- LinkedHashMap<String, String> partitionSpec =
pair.getKey();
- BinaryRow partitionRow = toPartitionRow(partitionSpec);
- if (partitionFilter == null ||
partitionFilter.test(partitionRow)) {
- try {
+ if (partitionManager != null) {
Review Comment:
I think we could refactor the code here; the `partitionManager` should be
renamed to `SplitEnumerator` so that it directly generates the corresponding
`Split`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
