jordepic commented on PR #618: URL: https://github.com/apache/paimon-rust/pull/618#issuecomment-5086672701
Thanks @JingsongLi — you're right, the hook resolved every path with the filesystem rules, so a scheme'd path like `s3://bucket/a` was silently mangled to `3://bucket/a`. Took your second suggestion and scoped the API explicitly: renamed to `with_fs_operator`, documented the filesystem contract (absolute paths, `file:` URLs, Windows drive paths, resolved against the operator's root), and `Storage::CustomFs` now rejects scheme'd paths with a clear error instead of misresolving them — object-store operators need the bucket/scheme resolution the built-in backends perform, which this hook deliberately doesn't reimplement. Added resolution and rejection tests, and fixed the rustfmt CI failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
