ArnavBalyan commented on code in PR #8853:
URL: https://github.com/apache/paimon/pull/8853#discussion_r3654649147
##########
paimon-core/src/main/java/org/apache/paimon/globalindex/GlobalIndexReadThreadPool.java:
##########
@@ -34,6 +35,7 @@ public class GlobalIndexReadThreadPool {
createCachedThreadPool(Runtime.getRuntime().availableProcessors(),
THREAD_NAME);
public static synchronized ExecutorService getExecutorService(int
threadNum) {
+ checkArgument(threadNum > 0, "Option 'global-index.thread-num' must be
greater than 0.");
Review Comment:
nit: Would it be helpful to add this in the option description for generated
config docs?
```
public static final ConfigOption<Integer> GLOBAL_INDEX_THREAD_NUM =
key("global-index.thread-num")
.intType()
.defaultValue(32)
.withDescription(
"The maximum number of concurrent threads for
global index I/O.");
```
`+ Must be greater than 0.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
