JingsongLi commented on code in PR #8857:
URL: https://github.com/apache/paimon/pull/8857#discussion_r3655467893
##########
paimon-common/src/main/java/org/apache/paimon/lookup/sort/db/LocalKvDb.java:
##########
@@ -549,7 +607,8 @@ private SstFileMetadata
findFileForKey(List<SstFileMetadata> sortedFiles, Memory
private SstFileMetadata writeMemTableToSst(TreeMap<MemorySlice, byte[]>
data)
throws IOException {
File sstFile = newSstFile();
- SortLookupStoreWriter writer = storeFactory.createWriter(sstFile,
null);
+ SortLookupStoreWriter writer =
+ storeFactory.createWriter(sstFile,
bloomFilterBuilderFactory.apply(data.size()));
Review Comment:
Thanks for pointing this out. This is a known limitation: the Bloom filter
hashes the raw serialized key bytes, while a custom comparator can define
broader equality, notably for different FLOAT/DOUBLE NaN payloads. We are
leaving this limitation unchanged in this PR for now and will address
comparator-consistent hashing or canonicalization separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
