XiaoHongbo-Hope commented on code in PR #8826:
URL: https://github.com/apache/paimon/pull/8826#discussion_r3655507211
##########
paimon-python/pypaimon/ray/data_evolution_merge_join.py:
##########
@@ -598,14 +606,31 @@ def _apply_group(group: pa.Table) -> pa.Table:
all_msgs: list = []
num_updated = 0
action_row_ids = []
- for batch in msgs_ds.iter_batches(batch_format="pyarrow"):
- for blob in batch.column("msgs_blob").to_pylist():
- all_msgs.extend(pickle.loads(blob))
- for n in batch.column("n_updated").to_pylist():
+ iter_batches_kwargs = {"batch_format": "pyarrow"}
+ if on_group_result is not None:
+ # Yield each group immediately.
Review Comment:
> `batch_size=1` does not yield each group immediately; it only splits
blocks after `map_groups` emits them. Ray buffers multiple group results within
the same task, so if a later group fails, earlier completed groups never reach
`on_group_result` and are not committed. This reproduces with
`num_partitions=1`, three groups, and `max_groups_per_commit=1`: when the third
group fails, the snapshot does not advance.
Fixed as of ac420260e: _apply_group returns each group’s failure as data
instead of
raising, so completed groups in the same task are still committed before
the error is
surfaced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
