jackylee-ch opened a new pull request, #621:
URL: https://github.com/apache/paimon-rust/pull/621

   `parse_memory_size` only recognized short unit spellings, so a valid Java 
option
   value such as `target-file-size = '256 mebibytes'` parsed as `None` and the 
caller
   silently fell back to its default. It also multiplied unchecked:
   `'9007199254740993 kb'` wraps to a negative size in a release build and 
panics in
   a debug build.
   
   **Fix**: accept every alias in Java `MemorySize.MemoryUnit` (`bytes`, 
`kibibytes`,
   `mebibytes`, `gibibytes`, `tebibytes` alongside the short forms), and use
   `checked_mul` so an overflowing value returns `None` — the callers then fall 
back
   to their default, which is what Java's thrown "numeric overflow" leads to as 
well.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to