leaves12138 commented on code in PR #8881:
URL: https://github.com/apache/paimon/pull/8881#discussion_r3663549736
##########
paimon-common/src/main/java/org/apache/paimon/lookup/sort/db/RecordCombiningWriter.java:
##########
@@ -55,12 +55,8 @@ void put(MemorySlice key, byte[] value) throws IOException {
}
if (isTombstone(value)) {
- if (pendingKey != null &&
mergeOperator.canMergeTombstone(pendingKey, key)) {
- pendingKeys.add(MemorySlice.wrap(key.copyBytes()));
- } else {
- flushPending();
- consumer.accept(key, value);
- }
+ flushPending();
Review Comment:
Confirmed with the author that this TTL behavior is intentional and aligned
with RocksDB. Withdrawing this concern; no change is required for this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
