QuakeWang commented on PR #8855: URL: https://github.com/apache/paimon/pull/8855#issuecomment-5111703894
Thanks @JingsongLi for catching this. You are right that `shutdownNow()` could interrupt reader cleanup after `take()` had already observed completion. Fixed in `d16774b2b`. `ParallelExecution.close()` now uses `shutdown()` when all readers have finished reading, while retaining `shutdownNow()` for early cancellation. I chose this approach to preserve the existing behavior where `take()` does not wait for reader cleanup. I also changed the test to use interruptible semaphore acquisition and propagate interruption as an `IOException`, so it now exposes this race. Both `ParallelExecutionTest` and `IndexBootstrapTest` pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
