hbgstc123 commented on code in PR #8631:
URL: https://github.com/apache/paimon/pull/8631#discussion_r3670508156
##########
paimon-core/src/main/java/org/apache/paimon/io/DataFileMeta.java:
##########
@@ -334,6 +334,17 @@ default Range nonNullRowIdRange() {
DataFileMeta assignSequenceNumber(long minSequenceNumber, long
maxSequenceNumber);
+ default DataFileMeta assignFileSource(FileSource fileSource) {
Review Comment:
DataFileMeta is @Public, so a default method avoids breaking external
implementations (same pattern as Table#newHybridSearchBuilder). However the
only implementation in Paimon project is PojoDataFileMeta, and it has a real
override. Happy to make it abstract
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
