sundapeng commented on PR #8900: URL: https://github.com/apache/paimon/pull/8900#issuecomment-5114330237
Thanks for the review, you are right. `LocalFileIO.newOutputStream` does `mkdirs(parent)` first and then opens the file, they are two steps. So an empty `_temporary` does not mean nobody is using it, another writer may be in the middle of these two steps. I updated the PR. Now `clean()` only deletes its own `tempPath`, and does not touch the `_temporary` directory anymore. The directory will stay there, and the writers who use it can remove it. Tests are updated too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
