JingsongLi commented on code in PR #8904:
URL: https://github.com/apache/paimon/pull/8904#discussion_r3672947592
##########
paimon-core/src/main/java/org/apache/paimon/append/dataevolution/DataEvolutionRowIdAssignmentPlanner.java:
##########
@@ -705,69 +742,95 @@ private PrimitiveRowRanges requiredLogicalRanges() {
}
}
- private static final class LegacyPartitionOrderKey
- implements Comparable<LegacyPartitionOrderKey> {
-
- private final long manifestGroupOrdinal;
- private final long firstRowId;
- private final int fileOrder;
- private final long maxSequenceNumber;
- private final String fileName;
- private final long retainedAddScanOrdinal;
-
- private LegacyPartitionOrderKey(
- long manifestGroupOrdinal,
- long firstRowId,
- int fileOrder,
- long maxSequenceNumber,
- String fileName,
- long retainedAddScanOrdinal) {
- this.manifestGroupOrdinal = manifestGroupOrdinal;
- this.firstRowId = firstRowId;
- this.fileOrder = fileOrder;
- this.maxSequenceNumber = maxSequenceNumber;
- this.fileName = fileName;
- this.retainedAddScanOrdinal = retainedAddScanOrdinal;
- }
-
- @Override
- public int compareTo(LegacyPartitionOrderKey other) {
- int comparison = Long.compare(manifestGroupOrdinal,
other.manifestGroupOrdinal);
- if (comparison != 0) {
- return comparison;
+ private static final class SelectedPartition {
+
+ private final BinaryRow partition;
+ private long minFirstRowId;
+ private PrimitiveRowRanges logicalRanges;
+
+ private SelectedPartition(
+ BinaryRow partition, long minFirstRowId, PrimitiveRowRanges
logicalRanges) {
+ this.partition = partition;
+ this.minFirstRowId = minFirstRowId;
+ this.logicalRanges = logicalRanges;
+ }
+
+ private void removeLargeContiguousRuns(long threshold, long[] result) {
Review Comment:
remove result and return real result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
