leaves12138 commented on code in PR #630:
URL: https://github.com/apache/paimon-rust/pull/630#discussion_r3679875762
##########
crates/paimon/Cargo.toml:
##########
@@ -115,7 +115,7 @@ urlencoding = "2.1"
paimon-mosaic-core = "0.2.0"
paimon-ftindex-core = { version = "0.1.0", optional = true }
tempfile = { version = "3", optional = true }
-paimon-vindex-core = "0.2.0"
+paimon-vindex-core = "0.3.0"
Review Comment:
Since `paimon-vindex-core` 0.3.0 intentionally removes the IVF-HNSW
implementations, please complete that removal on the Paimon side as part of
this bump. `is_vindex_index_type` / `native_index_type` still accept
`ivf-hnsw-flat` and `ivf-hnsw-sq`; `SUPPORTED_GLOBAL_INDEX_TYPES_FOR_DROP`, the
DataFusion procedure validation message, and the SQL documentation also
continue to advertise them. Consequently, `create_global_index` accepts either
type and only fails later in `VectorIndexConfig::from_options` with `unknown
index.type`.
Please remove the stale identifiers, option handling, validation branches,
documentation, and related tests (or reject them explicitly before invoking
vindex-core) so the public supported-type surface matches the upgraded
dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
