juntaozhang commented on code in PR #8574:
URL: https://github.com/apache/paimon/pull/8574#discussion_r3680126443
##########
paimon-core/src/main/java/org/apache/paimon/table/source/SplitSerializer.java:
##########
@@ -182,15 +183,26 @@ private static void writeChainSplit(ChainSplit split,
DataOutputView out) throws
writeDataFiles(split.dataFiles(), out);
writeStringMap(out, split.fileBucketPathMapping());
writeStringMap(out, split.fileBranchMapping());
+ DeletionFile.serializeList(out, split.deletionFiles().orElse(null));
}
private static ChainSplit readChainSplit(DataInputView in) throws
IOException {
BinaryRow logicalPartition = deserializeBinaryRow(in);
Review Comment:
Thanks for the detailed explanation.
I've updated it to keep `SplitSerializer.VERSION = 1` and use versioned
serialization in `ChainSplit` instead.
PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
