leaves12138 commented on code in PR #8920:
URL: https://github.com/apache/paimon/pull/8920#discussion_r3680449073
##########
paimon-core/src/test/java/org/apache/paimon/rest/RESTCatalogServer.java:
##########
@@ -2777,6 +2779,12 @@ private MockResponse commitSnapshot(
if (!tableId.equals(table.catalogEnvironment().uuid())) {
throw new Catalog.TableNotExistException(identifier);
}
+ TableSnapshot currentSnapshot =
tableLatestSnapshotStore.get(identifier.getFullName());
+ String currentSnapshotUuid =
+ currentSnapshot == null ? null :
currentSnapshot.snapshot().uuid();
+ if (!Objects.equals(currentSnapshotUuid, baseSnapshotUuid)) {
Review Comment:
Understood. Since this repository provides the client/library and the test
server intentionally exercises the strict post-upgrade contract, treating
mixed-version acceptance as a production server policy is reasonable. Thanks
for clarifying.
##########
paimon-core/src/main/java/org/apache/paimon/catalog/Catalog.java:
##########
@@ -739,6 +740,7 @@ default boolean supportsListTableByType() {
boolean commitSnapshot(
Identifier identifier,
@Nullable String tableUuid,
+ @Nullable String baseSnapshotUuid,
Review Comment:
Understood. Given that this is the 2.0 development line and the API change
is intentional, keeping a single canonical API is reasonable. Thanks for
clarifying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
