jackylee-ch opened a new pull request, #637:
URL: https://github.com/apache/paimon-rust/pull/637

   Both `CONTRIBUTING.md` and `docs/src/contributing.md` tell contributors to 
run a
   bare `cargo test`. On macOS that aborts before running a single test — the
   workspace includes the `pypaimon_rust` binding and the test binary fails to 
link
   `libpython3.12.dylib` (SIGABRT). CI never runs it that way; it uses
   `cargo test -p paimon --all-targets --features fulltext,vortex`.
   
   `CONTRIBUTING.md` also claimed "only `cargo` is needed" and listed `cargo 
bench`.
   Four of the five integration suites read a Paimon warehouse written by Spark 
via
   `make docker-up`; without it 57 tests fail with `TableNotExist` rather than 
being
   skipped. And there is no `[[bench]]` target or benchmark harness in the
   workspace, so `cargo bench` runs nothing.
   
   **Fix**: list the commands CI actually runs, including the `--features` and
   `-D warnings` flags from the `check` job, and document the Docker step the
   integration suites require. Every command in the new text was run locally.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to