jackylee-ch opened a new pull request, #640:
URL: https://github.com/apache/paimon-rust/pull/640
Three accessor doc comments in `core_options.rs` state defaults that
disagree with
the constants right next to them:
- `bucket()` says "Default is 1" but `DEFAULT_BUCKET` is `-1`. The existing
test
asserts `bucket() == -1`, and Java defaults to `-1` too — the comment is
the
only thing wrong.
- `target_file_size()` says "Default is 128MB" but
`DEFAULT_TARGET_FILE_SIZE` is
256 MiB. Java gives this option no default and documents 128 MB for
primary-key
tables / 256 MB for append tables, so the comment now records which one
this
returns.
- `dynamic_bucket_target_row_num()` claims 200,000 "matching Java Paimon",
but
Java defaults `dynamic-bucket.target-row-num` to 2,000,000. This states the
difference rather than asserting parity; **the constant is left
unchanged** —
happy to follow up if you want the value aligned instead.
Comments only, no behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
