lxy-9602 commented on code in PR #172:
URL: https://github.com/apache/paimon-cpp/pull/172#discussion_r3704333127
##########
src/paimon/format/parquet/parquet_file_batch_reader_test.cpp:
##########
@@ -646,6 +646,98 @@ TEST_F(ParquetFileBatchReaderTest,
TestReadSchemaWithMapSelectedKeysMetadata) {
<< "expected: " << expected_array->ToString() << "\nactual: " <<
result_array->ToString();
}
+TEST_F(ParquetFileBatchReaderTest,
TestNestedListTimestampTimezoneAndMapFieldName) {
+ const std::string timezone = "Asia/Shanghai";
Review Comment:
Could we extend the test coverage for both newly supported nested timestamp
projection cases?
First, please add a focused `ParquetFileBatchReaderTest` for a nested MILLI
-> SECOND conversion, for example with `list<struct<..., timestamp(SECOND)>>`.
The existing test only covers the nested MICRO timezone-only case and does not
exercise the unit-conversion branch allowed by this guard.
In addition, please add E2E write-and-read cases for both scenarios in
`write_and_read_inte_test.cpp`:
1. nested MILLI -> SECOND unit conversion;
2. nested MICRO timestamp with a timezone-only difference.
This would verify both the reader-level conversion logic and the complete
Parquet write/read path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
