JingsongLi commented on PR #8323: URL: https://github.com/apache/paimon/pull/8323#issuecomment-5174122742
-The JDBC pool cache key and concurrent close handling are basically correct. -But JdbcCatalog. close() becomes no op, and cache does not have reference counting, idle evil, or explicit removal mechanisms in the production environment. -Each set of different configuration/rotation credentials in the long-term JVM will permanently retain the connection until JVM shutdown; The term 'idle after review' referred to in the code comments is not actually implemented, which violates the resource release semantics of 'Catalog. close()'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
