jackylee-ch opened a new pull request, #670: URL: https://github.com/apache/paimon-rust/pull/670
A non-`none` `changelog-producer` on a table without primary keys was accepted at both create and alter time. An append table has no merge step, so no changelog can ever be produced: the option is persisted into the schema and then silently ignored by the write path, which derives `input_changelog` from the producer alone and never reaches a compaction that could emit changelog files. Users get a table that claims to produce a changelog and quietly does not. Java rejects this in `SchemaValidation#validateTableSchema` with "Can not set changelog-producer on table without primary keys, please define primary keys." **Fix**: add `validate_changelog_producer_requires_primary_keys` to `Schema::validate_final_schema`, so it runs on both paths, as #660 arranged. Only a non-`NONE` producer is rejected — an append table may still spell the default out explicitly, matching Java's `!= ChangelogProducer.NONE` guard. No behavior change for any table that has primary keys, or for `changelog-producer=none`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
