JingsongLi commented on code in PR #8930:
URL: https://github.com/apache/paimon/pull/8930#discussion_r3712090800
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/globalindex/GenericGlobalIndexBuilder.java:
##########
@@ -67,13 +67,6 @@ public List<ManifestEntry> scan() {
+ "but table '%s' has bucket = %d.",
table.name(),
table.coreOptions().bucket());
- checkArgument(
- !table.coreOptions().deletionVectorsEnabled(),
- "Generic global index does not support tables with deletion
vectors enabled. "
- + "Table '%s' has 'deletion-vectors.enabled' = true,
which may cause "
- + "deleted rows to be indexed.",
- table.name());
-
scanSnapshot = table.snapshotManager().latestSnapshot();
Review Comment:
Let add support to full-text too.
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/globalindex/GenericGlobalIndexBuilder.java:
##########
@@ -67,13 +67,6 @@ public List<ManifestEntry> scan() {
+ "but table '%s' has bucket = %d.",
table.name(),
table.coreOptions().bucket());
- checkArgument(
- !table.coreOptions().deletionVectorsEnabled(),
- "Generic global index does not support tables with deletion
vectors enabled. "
- + "Table '%s' has 'deletion-vectors.enabled' = true,
which may cause "
- + "deleted rows to be indexed.",
- table.name());
-
scanSnapshot = table.snapshotManager().latestSnapshot();
Review Comment:
Let‘s add support to full-text too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
