QuakeWang commented on code in PR #669:
URL: https://github.com/apache/paimon-rust/pull/669#discussion_r3717565628


##########
docs/src/sql.md:
##########
@@ -1754,6 +1772,39 @@ Columns:
 | `min_row_id` | BIGINT | Minimum row id covered (when row tracking is 
enabled) |
 | `max_row_id` | BIGINT | Maximum row id covered (when row tracking is 
enabled) |
 
+### $files
+
+View the data files of the current snapshot, with per-file statistics:
+
+```sql
+SELECT * FROM paimon.default.my_table$files;
+```
+
+Columns:
+
+| Column | Type | Description |
+|---|---|---|
+| `partition` | STRING | Partition spec for the file, or `NULL` for 
unpartitioned tables |
+| `bucket` | INT | Bucket id the file belongs to |
+| `file_path` | STRING | Data file name |

Review Comment:
   `file_path` contains the full data file path, using `external_path` when 
present, rather than only the data file name.



##########
docs/src/sql.md:
##########
@@ -1754,6 +1772,39 @@ Columns:
 | `min_row_id` | BIGINT | Minimum row id covered (when row tracking is 
enabled) |
 | `max_row_id` | BIGINT | Maximum row id covered (when row tracking is 
enabled) |
 
+### $files
+
+View the data files of the current snapshot, with per-file statistics:
+
+```sql
+SELECT * FROM paimon.default.my_table$files;
+```
+
+Columns:
+
+| Column | Type | Description |
+|---|---|---|
+| `partition` | STRING | Partition spec for the file, or `NULL` for 
unpartitioned tables |

Review Comment:
   The Rust implementation returns `"{}"` for unpartitioned tables, not `NULL`, 
so this description does not match the actual `$files` output.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to