thswlsqls opened a new pull request, #9059:
URL: https://github.com/apache/paimon/pull/9059

   ### Purpose
   
   fix #9058
   
   - Omitting a required action argument produces an exception that does not 
say **which** argument is missing: `merge_into` throws a bare 
`NullPointerException`, `create_tag_from_timestamp` and 
`create_tag_from_watermark` throw `NumberFormatException: null`.
   - Those four arguments (`merge_actions`, `timestamp`, `tag`, `watermark`) 
are read with `params.get(...)` and dereferenced at once.
   - Their sibling arguments already use `params.getRequired(...)`, which 
reports `Argument '<name>' is required.`; `DropPartitionActionFactory` enforces 
the same contract.
   - Same defect class as #8611, which fixed only the `migrate_*` factories.
   
   ### Tests
   
   - Added `MergeIntoActionFactoryTest`, 
`CreateTagFromTimestampActionFactoryTest` and 
`CreateTagFromWatermarkActionFactoryTest` (7 tests). The four missing-argument 
tests fail without this change.
   - `mvn -pl paimon-flink/paimon-flink-common -Pflink1 -DfailIfNoTests=false 
clean install` — BUILD SUCCESS, 2258 tests, 0 failures, 8 skipped.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to