zjw1111 commented on code in PR #182:
URL: https://github.com/apache/paimon-cpp/pull/182#discussion_r3726699879
##########
src/paimon/common/utils/arrow/arrow_input_stream_adapter.cpp:
##########
@@ -43,6 +43,19 @@ arrow::Status ValidateArrowIoRange(int64_t value, const
char* name) {
return arrow::Status::OK();
}
+struct BufferWithMemoryPool {
Review Comment:
could you please modify the PR title to conventional commits style, and add
a TODO assigned to xinyu, noting that performance will be optimized later.
##########
src/paimon/common/utils/arrow/arrow_input_stream_adapter.cpp:
##########
@@ -43,6 +43,19 @@ arrow::Status ValidateArrowIoRange(int64_t value, const
char* name) {
return arrow::Status::OK();
}
+struct BufferWithMemoryPool {
Review Comment:
copied from https://github.com/alibaba/paimon-cpp/pull/464
<img width="1556" height="962" alt="Image"
src="https://github.com/user-attachments/assets/6a9a0082-e683-46f2-be2b-301f55891014";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
