liujiayi771 commented on code in PR #9089:
URL: https://github.com/apache/paimon/pull/9089#discussion_r3733944242
##########
paimon-python/pypaimon/api/token_loader.py:
##########
@@ -216,4 +260,12 @@ def create_token_loader(options: Options) ->
Optional['DLFTokenLoader']:
)
role_name = options.get(CatalogOptions.DLF_TOKEN_ECS_ROLE_NAME)
return DLFECSTokenLoader(ecs_metadata_url, role_name)
+ if loader == 'local_file':
Review Comment:
Thanks for catching this! You are right. I updated `AuthProviderFactory` to
select a single credential source: when an explicit token loader or the
implicit `local_file` loader from `dlf.token-path` is present, the provider now
gets `token=None`, so the loader takes precedence over static AK/SK, matching
Java. Unknown explicit loader names now fail instead of falling back to static
credentials. I also added regression coverage for mixed configurations with
both implicit `dlf.token-path` and explicit `dlf.token-loader=local_file`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
