sundapeng opened a new pull request, #9121: URL: https://github.com/apache/paimon/pull/9121
> **Stacked on #9120** — that commit shows up here too until it merges. Review only > `[core] Carry the row count and byte size a format table writer already counted`. ### Purpose `FormatTableRollingFileWriter` counts every row it writes and `FormatTableSingleFileWriter` knows the byte length of the file it closed. Both numbers are then dropped: `closeAndGetCommitters` returns only the committers, and `prepareCommit` wraps each one in a `TwoPhaseCommitMessage` that carries nothing else. Anything downstream that wants to know what a commit wrote has to go back to the filesystem and list it. This keeps the two numbers attached to the file they describe, in a new `FormatTableWrittenFile` that pairs the committer with them, and lets `TwoPhaseCommitMessage` carry it. **Nothing reads them yet.** That is deliberate — this PR has no behaviour to review, only a data flow that stops throwing information away. ### What is deliberately not touched `TwoPhaseOutputStream.Committer`. `RenamingTwoPhaseOutputStream` is `@Public`, so adding a method to the type its `committer()` returns would break external implementations. The counts ride the paimon-core commit message instead. ### Context Next in the stack behind #9120. A catalog-managed format table has no snapshot, so it has no channel for partition statistics; the numbers a commit could report are exact and free here, and are currently discarded at this point. ### API and Format New paimon-core internal class `FormatTableWrittenFile`. No public API change. No format change — nothing new is written to storage. ### Documentation None needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
