Stephen0421 commented on PR #9099: URL: https://github.com/apache/paimon/pull/9099#issuecomment-5234971860
> Thanks for adding primary-key BLOB support to PyPaimon. I compared the change carefully with the Java implementation and found several correctness, compatibility, and lifecycle issues in the inline comments below. > > Separately, this PR is too large to review safely as one change: it touches 52 files with +5,352/-330 lines and combines managed-BLOB persistence, sidecar lifecycle, PK read/write routing, descriptor/view resolution, schema validation, staged commit ownership, and dynamic-bucket commit callbacks. Please consider splitting it into dependency-ordered PRs, for example: > > 1. shared descriptor/config compatibility and reusable BLOB writer fixes; > 2. managed-BLOB reference format and lifecycle; > 3. primary-key managed-BLOB write support; > 4. primary-key managed-BLOB/read-view support; > 5. dynamic-bucket callback and retry wiring. > > That would make Java parity, failure-path ownership, and interoperability much easier to verify and would substantially reduce regression risk. > > Local verification on this head: 59 targeted tests passed (plus 15 subtests), and `git diff --check` passed. The failure scenarios described inline are not covered by the current tests. Thanks for review, I will consider separate it as several prs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
