ArnavBalyan commented on PR #9134: URL: https://github.com/apache/paimon/pull/9134#issuecomment-5236969552
> While `IN (existing, missing)` skips non-existent snapshots or schemas, the case where `snapshot_id = missing` is still hardcoded in new tests to throw an exception; this creates inconsistent predicate semantics for the same system table, whereas returning an empty set for non-existent IDs would be more logical for SQL queries. Additionally, the `exists → read` flow remains susceptible to a TOCTOU (Time-of-Check to Time-of-Use) race condition involving snapshot expiration. Hi @JingsongLi thanks for review, have updated the equality semantics to match IN filter, both do not fail on invalid snapshot ids, also fixed the TOCTOU concern. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
