juntaozhang commented on PR #8185: URL: https://github.com/apache/paimon/pull/8185#issuecomment-5263467636
Thank you, @JingsongLi for the careful review. I have addressed the four concerns as follows: **1. Granularities missing a day field (yyyy, yyyyMM, quarters, etc.)** > Added validation in PartitionTimeResolver: the formatter must specify a complete date, either year-month-day or year-day-of-year; otherwise it fails fast. **2. Non-unique fields (AM/PM, week-of-month, etc.)** > Restricted FIELD_MAP to round-trippable fields only: y/u, M/L, d, D, H, k, m, s. Letters such as a, h, K, w, W, E, e, c, F, G, Y, Q, q are no longer supported and are rejected as unsupported formatter letters. **3. Y (week-based year) incrementing on the standard calendar year** > Since Y has been removed from FIELD_MAP, week-based-year formats are no longer accepted, avoiding the incorrect Period.ofYears(1) increment entirely. **4. Millisecond/nanosecond enumeration explosion** > Two layers of protection: > - extractMinStep() rejects any step smaller than one second. > - ChainTableUtils.getDeltaPartitions() estimates the partition count ahead of the loop using ChronoUnit and throws if it exceeds MAX_DELTA_PARTITIONS (10 million). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
