leaves12138 commented on code in PR #9191:
URL: https://github.com/apache/paimon/pull/9191#discussion_r3764914135
##########
paimon-core/src/test/java/org/apache/paimon/JavaPyE2ETest.java:
##########
@@ -388,7 +388,7 @@ public void testPKDeletionVectorWrite() throws Exception {
Path tablePath = new Path(warehouse.toString() + "/default.db/" +
tableName);
FileStoreTable table = createFileStoreTable(optionsSetter, tablePath);
StreamTableWrite write = table.newWrite(commitUser);
- IOManager ioManager = IOManager.create(tablePath.toString());
+ IOManager ioManager = IOManager.create(tempDir.toString());
Review Comment:
These E2E tests now spill into `paimon-python/pypaimon/tests/e2e`, but the
externally supplied `IOManager` is never closed. `TableWriteImpl.close()` only
closes the underlying writer and does not own or close the injected manager. I
ran `JavaPyE2ETest#testPKDeletionVectorWrite` and it left a
`pypaimon/tests/e2e/paimon-io-...` directory behind; `run_mixed_tests.sh` only
cleans `e2e/warehouse`. This therefore moves the test pollution rather than
eliminating it. Could we close the `IOManager` explicitly (preferably with
try-with-resources), or use a real per-test temporary directory and still close
it? The same issue applies to all three changed sites in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
