QuakeWang commented on code in PR #648: URL: https://github.com/apache/paimon-rust/pull/648#discussion_r3772981539
########## crates/paimon/examples/create_table.rs: ########## @@ -0,0 +1,132 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::collections::HashMap; +use std::error::Error; +use std::sync::Arc; + +use arrow_array::{Int32Array, RecordBatch, StringArray}; +use arrow_schema::{DataType as ArrowDataType, Field, Schema as ArrowSchema}; +use paimon::catalog::Identifier; +use paimon::spec::{DataType, IntType, Schema, VarCharType}; +use paimon::{Catalog, CatalogFactory, CatalogOptions, Options}; + +// This example creates a paimon table and inserts test data +// Run the example by passing the catalog warehouse path after `--`: +// cargo run --package paimon --example create_table -- /path/to/warehouse +#[tokio::main] +async fn main() -> Result<(), Box<dyn Error>> { + let mut args = std::env::args().skip(1); + + let warehouse = args.next().ok_or_else(|| { + std::io::Error::new( + std::io::ErrorKind::InvalidInput, + "usage: cargo run --package paimon --example create_table -- <warehouse-path> ", + ) + })?; + + let overwrite = args.any(|arg| arg == "--overwrite"); Review Comment: Could we make `--overwrite` order-independent, or document the required order? The first argument is always treated as the warehouse, so `--overwrite <warehouse-path>` fails; only `<warehouse-path> --overwrite` works. At minimum, please update the usage string to `<warehouse-path> [--overwrite]`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
