juntaozhang commented on PR #9204: URL: https://github.com/apache/paimon/pull/9204#issuecomment-5292912854
> * Python `datetime` encoding relies on a floating-point calculation (`total_seconds() * 1_000_000`), which leads to a loss of microsecond precision for dates far removed from the epoch. > > * Empirical testing shows a round-trip for `9998-07-08 ...654321` results in `...654336` (an error of 15μs); errors of ±1μs also occur for the years 1600, 1900, 2500, and 5000. > > * The implementation should be changed to use pure integer arithmetic based on `days`, `seconds`, and `microseconds`. @JingsongLi Thanks for your review. I have fixed the issue, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
