JingsongLi commented on PR #9233: URL: https://github.com/apache/paimon/pull/9233#issuecomment-5302164146
In `ObjectsFile.writeWithoutRolling`, if `writer.close()` (or the write operation itself) throws an exception and the subsequent `out.close()` in the `finally` block also throws an exception, the latter will still overwrite the original exception; thus, the claim in the PR that the "original exception propagates" is incorrect. It is recommended to use try-with-resources in the outer scope so that any exception thrown during closing is added to the list of suppressed exceptions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
