Stephen0421 commented on code in PR #9148:
URL: https://github.com/apache/paimon/pull/9148#discussion_r3790818853
##########
paimon-python/pypaimon/common/options/core_options.py:
##########
@@ -1213,7 +1222,14 @@ def variant_shredding_schema(self) -> Optional[str]:
return val
def blob_descriptor_fields(self, default=None):
- value = self.options.get(CoreOptions.BLOB_DESCRIPTOR_FIELD, default)
+ value = self.options.get(CoreOptions.BLOB_DESCRIPTOR_FIELD, None)
Review Comment:
Agreed. Python master ignored that key and wrote dedicated `.blob` payloads,
so treating it as a global `blob-descriptor-field` fallback is unsafe for
rolling upgrades. `blob_descriptor_fields()` now only honors the canonical
`blob-descriptor-field`. Column directives still migrate the legacy key onto
the canonical option. Added master-layout write/read coverage with the legacy
key only (`test_legacy_stored_descriptor_fields_keeps_dedicated_blob_layout`,
`test_blob_descriptor_fields_ignores_legacy_stored_key`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
