Gabriel39 commented on code in PR #9243:
URL: https://github.com/apache/paimon/pull/9243#discussion_r3791044977
##########
paimon-core/src/main/java/org/apache/paimon/table/format/FormatTableRead.java:
##########
@@ -73,6 +74,12 @@ public TableRead withIOManager(IOManager ioManager) {
return this;
}
+ @Override
+ public TableRead withReadBatchSizeController(ReadBatchSizeController
controller) {
+ read.withReadBatchSizeController(controller);
Review Comment:
Fixed in 05d567f. The controller is now scoped to each FormatTableRead.
Reader creation captures the controller reference, and lazy file suppliers
retain that binding while requested-size updates through the same controller
remain dynamic. I added ORC-backed multi-read isolation and ReadBuilder
serialization regression tests.
##########
paimon-core/src/main/java/org/apache/paimon/table/source/InnerTableRead.java:
##########
@@ -63,6 +64,11 @@ default InnerTableRead forceKeepDelete() {
return this;
}
+ @Override
+ default InnerTableRead withReadBatchSizeController(ReadBatchSizeController
controller) {
+ return this;
Review Comment:
Fixed in 05d567f. AuditLogRead now delegates to its physical dataRead, which
also covers BinlogRead, and LookupCompactDiffRead delegates to both lookup
phases. I also audited lazy physical-read paths and propagated the controller
to the data-evolution blob-view prescan. Regression tests cover audit log,
binlog, lookup, and blob prescan propagation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
