shyjsarah commented on code in PR #711:
URL: https://github.com/apache/paimon-rust/pull/711#discussion_r3793750490
##########
crates/paimon/src/vindex/reader.rs:
##########
@@ -225,13 +296,16 @@ impl VindexVectorGlobalIndexReader {
message: "vindex metadata not initialized".to_string(),
source: None,
})?;
- search_batch_vindex(
+ let (results, batch_stats) = search_batch_vindex(
reader,
metadata,
&self.options,
vector_searches,
self.batch_index_parallelism,
- )
+ self.timing_enabled,
+ )?;
+ self.batch_stats = batch_stats;
Review Comment:
**Minor:** `search_batch()` stores the collected stats on the reader, but
only `visit_batch_vector_search()` consumes them and emits
`paimon_vindex_reader`. The PK-vector scorer calls `load_validated()` +
`search_batch()` directly (`vector_search_builder.rs:923-935`), so with timing
enabled that route collects batch/range-I/O diagnostics but returns without
publishing them.
Could we make telemetry reporting independent of the convenience wrapper
(for example, return/commit the stats from the search API or pass an explicit
diagnostics reporter), and add coverage for the PK/hybrid route?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
