lxy-9602 commented on code in PR #208:
URL: https://github.com/apache/paimon-cpp/pull/208#discussion_r3794256099
##########
src/paimon/testing/mock/mock_file_system.h:
##########
@@ -121,15 +102,15 @@ class MockFileSystem : public FileSystem {
Status Delete(const std::string& path, bool recursive = true) const
override {
return Status::OK();
}
- Result<std::unique_ptr<FileStatus>> GetFileStatus(const std::string& path)
const override {
- return std::make_unique<MockFileStatus>();
+ Result<FileStatus> GetFileStatus(const std::string& path) const override {
+ return FileStatus(/*path=*/"", /*length=*/0, /*is_dir=*/false,
/*modification_time=*/0);
Review Comment:
Which value do we plan to use here — `0`, `kUnknownModificationTime` and
`kNoSize`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
