zhuxiangyi commented on PR #8334: URL: https://github.com/apache/paimon/pull/8334#issuecomment-5313991512
@JingsongLi Thanks for the detailed review — the reproductions saved a lot of time. All six comments are addressed, and the mixed-version barrier is documented on data-evolutevery reader, writer, compactor and maintenance job must be upgraded before enabling it, anddowngrading is unsafe once a file whose write columns contain a nested sub-field path has been committed. Two notes for the re-review: - The ordering and null regressions are covered end to end, and I validated each test by reverting the fix and confirming it fails first. The clause shapes matter — a single WHEN MATCHED clause is normalized into schema order by Spark's own alignment, and an unmatched row keeps its parent-struct n, so neither reproduces the bugs. - On the a.b ambiguity I implemented the "reject" option rather than changing the persisted writeCols format — glad to do the encoding in a follow-up or here, your call. Also added coverage for two previously untested paths: compaction over sub-field files, and adding a nested sub-field after such files exist. CI is green. Please take another look when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
