vbabenkoru commented on code in PR #9245:
URL: https://github.com/apache/paimon/pull/9245#discussion_r3801585809


##########
paimon-iceberg/pom.xml:
##########
@@ -356,4 +373,71 @@ under the License.
 
     </dependencies>
 
+
+    <profiles>
+        <profile>
+            <!-- GA row-lineage validation: builds and runs this module 
against Iceberg 1.11,
+                 the reference implementation of Iceberg format-version 3 row 
lineage. Iceberg
+                 1.10+ ships Java-17 bytecode, so this profile requires JDK 17 
and stays
+                 opt-in: the default build keeps Iceberg 1.8.1 so the module 
compiles and
+                 tests on the JDK 11 CI, where GA-only reader assertions skip 
themselves. -->
+            <id>iceberg-ga</id>
+            <properties>
+                <iceberg.version>1.11.0</iceberg.version>

Review Comment:
   Fixed.
   
   A single `mvn test -am` session replaces the not-yet-built `paimon-bundle` 
with its unshaded constituent modules, whose direct Avro references clash with 
the Avro 1.12 line Iceberg 1.11 requires; the installed bundle relocates Avro, 
so there is no clash (and pinning Avro either way breaks one side — 1.11 lacks 
`LogicalTypes.timestampNanos` for Iceberg, 1.12 drops `DataBlock.getNumEntries` 
for unshaded Paimon). Added a JDK 17 workflow (`utitcase-iceberg-ga.yml`) that 
installs the shaded bundle first and then runs the full suite under 
`-Piceberg-ga`, and documented the two-step invocation in the profile. 
Verified: 55 tests, 0 failures, 0 skips under the profile; 55/0 with 2 GA-only 
skips on the default JDK 11 build.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to