ArnavBalyan commented on code in PR #9287:
URL: https://github.com/apache/paimon/pull/9287#discussion_r3802592574
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/service/QueryExecutorOperator.java:
##########
@@ -128,6 +130,10 @@ public void processElement(StreamRecord<InternalRow>
streamRecord) throws Except
@Override
public void close() throws Exception {
super.close();
+ // shut down the server first, so that no in-flight request can hit
the closed query
+ if (server != null) {
+ server.shutdown();
Review Comment:
nit: shutdown returns after swallowing any exceptions, causing query close
when the server is not really shut down. It would be better to assert it in a
follow up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
